New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(author-box): don't use click handler for links #697

Merged

trieloff merged 2 commits into main from author-link

Dec 18, 2024

Contributor

trieloff commented Dec 13, 2024 •

edited by rofe

Loading

see https://author-link--helix-website--adobe.aem.page/blog/sidekick-v7

@asthabh23 not sure why you used a click handler in the first place, but this PR replaces it with native links


          fix(author-box): don't use click handler for links

61b48f6

aem-code-sync bot temporarily deployed to author-link

December 13, 2024 13:52

Inactive

aem-code-sync bot commented Dec 13, 2024 •

edited

Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

Re-run PSI checks
Re-sync branch

Commits

a104e16 ✅ (latest)
61b48f6 ✅

trieloff requested review from asthabh23 and rofe

December 13, 2024 13:53

Contributor

rofe commented Dec 13, 2024

@trieloff the click on the avatar is still broken: the URL in the opened popup is https://github.com/https://github.com/<gh-id> - i can switch to using just the ID in the github metadata property, but then the link on the right hand side breaks (trying to open ./<gh-id> as a relative link. Ideally both links would expect and work at the same time.


          fix: sharing link for github id or url

a104e16

aem-code-sync bot deployed to author-link

December 13, 2024 16:04

View deployment

aem-code-sync bot commented Dec 13, 2024

	Page	Scores	Audits	Google
📱	/blog/sidekick-v7
🖥️	/blog/sidekick-v7

Contributor

rofe commented Dec 13, 2024

added support for github IDs or URLs
used the same event listener for both author avatar and sharing link
removed window settings to open a new tab instead of a popup

rofe approved these changes

View reviewed changes

trieloff merged commit 0de3559 into main

4 checks passed

trieloff deleted the author-link branch

December 18, 2024 09:09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet